Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate non empty value #7377

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Nov 5, 2024

Description

Related GitHub issue(s)

Fixes #7376

Testing instructions

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See '....'

Screenshots / screencast

Changelog text for these changes

PR checklist

@JoryHogeveen JoryHogeveen added Type: Bug Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pending QA needs to be done labels Nov 5, 2024
@JoryHogeveen JoryHogeveen added this to the Next Release milestone Nov 5, 2024
@JoryHogeveen JoryHogeveen self-assigned this Nov 5, 2024
Copy link

what-the-diff bot commented Nov 5, 2024

PR Summary

  • Enhancement to process_magic_tags Method’s Return Value
    A more comprehensive condition for returning a value in the process_magic_tags method has been introduced. This updated condition also includes numeric values. Previously, the method only returned when the value was not null and not false. The new condition will return in case the value is any value, numeric, or not. This extends the flexibility of functions that depend upon this particular method.

@JoryHogeveen JoryHogeveen added Status: PR > QA pass QA passed and removed Status: PR > QA pending QA needs to be done labels Nov 6, 2024
sc0ttkclark
sc0ttkclark previously approved these changes Nov 17, 2024
@sc0ttkclark sc0ttkclark changed the base branch from main to release/3.2.8 November 17, 2024 00:10
@sc0ttkclark sc0ttkclark dismissed their stale review November 17, 2024 00:10

The base branch was changed.

@sc0ttkclark sc0ttkclark merged commit 2e48b70 into release/3.2.8 Nov 17, 2024
9 of 13 checks passed
@sc0ttkclark sc0ttkclark deleted the feature/7376-empty-magic-tag branch November 17, 2024 00:13
@sc0ttkclark sc0ttkclark modified the milestones: Next Release, Pods 3.2.8 Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pass QA passed Type: Bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Magic tag with empty string as value still returns before and after
2 participants