fix: setting path pattern in opentelemetry traces #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompuIves
force-pushed
the
feat/path-pattern-opentelemetry
branch
from
963f0b5 to
13dff7f
Compare
|
thanks 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the OpenTelemetry Tracing middleware, the path pattern is not set as an attribute. I think that's because the
PathPatternis initialized when the request is "called". Similar to this PR, I have moved the setting of the attribute to after the request is called.As a second change (which might be considered breaking), I am renaming the span to
:method :patterninstead of:method :uri. This is recommended by OpenTelemetry: https://opentelemetry.io/docs/specs/otel/trace/api/#span.