Speed up dev_beta_binom() by adding a scalar version of the log-likelihood function, a vectorized optimization routine, and memoization.
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nehill197
commented
Aug 12, 2024
nehill197
commented
- Added a scalar case to the log-likelihood function to improve speed for scalar inputs.
- Add memoization (if package is installed) and data has > 800 rows to gain speed from repeated function calls.
- Use a vectorized optimization function to improve speed of optimization required for deviance calculation.
…on for the beta-binomial distribution
joethorley
approved these changes
Aug 12, 2024
…n scalar log likelihood calculation
joethorley
requested changes
Aug 13, 2024
joethorley
requested changes
Aug 13, 2024
R/log-lik.R
Outdated
| # x and size unchanged; memoize it to reduce repeated calls | ||
| # when length(x) is large enough to outweigh the overhead required by memoize. | ||
| # For length(x) < 800, memoize is slower | ||
| # https://poissonconsulting.slack.com/archives/C07FC57Q346/p1723248220478269 |
There was a problem hiding this comment.
I would delete this link as it's public repo and only works for poisson folks. Add info to an issue in extras and link to that if critical.
|
Going to wait to merge until current CRAN submission is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.