Proper fix for emu8950 missing note issue #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing workaround for missing note issue with proper fix by Mitsutaka Okazaki author of emu8950
remove spaces from last commit
|
Thank you @TerryFi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced workaround for #46 with proper fix from https://github.com/digital-sound-antiques/emu8950. Link to original emu8950 commit digital-sound-antiques/emu8950@570dc99.
Compared both the new fix and previous workaround sample audio to hardware opl audio output. Workaround shows inaccurate note attack timing whereas the new fix attack timing shows good accuracy. The inaccuracies were verified to be caused by changes in previous workaround.