Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use=runtimestats heap test #4553

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

dipinhora
Copy link
Contributor

resolves #4551

@SeanTAllen
Copy link
Member

@dipinhora shall we merge this before or after #4552 ?

@dipinhora
Copy link
Contributor Author

@dipinhora shall we merge this before or after #4552 ?

umm... good question.. my brain isn't working well enough for me to make a decision on this as it seems circular in nature.. 8*/

@SeanTAllen
Copy link
Member

@dipinhora let's do this second.

@dipinhora
Copy link
Contributor Author

@dipinhora let's do this second.

cokey dokey.. i'll rebase onto main once the other PR is merged..

@SeanTAllen
Copy link
Member

SeanTAllen commented Nov 27, 2024

@dipinhora can you rebase this against main? once that is done and tests pass, i'll merge.

@dipinhora
Copy link
Contributor Author

@dipinhora can you rebase this against main? once that is done and tests pass, i'll merge.

done

@SeanTAllen SeanTAllen merged commit b8dde98 into ponylang:main Nov 28, 2024
21 checks passed
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling with use=runtimestats causes Heap.Init test to fail
3 participants