[ShortCircuit] Add CONFIGURED initial voltage profile and voltage ranges
#759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneLt
changed the title
EtienneLt
force-pushed
the
add-new-shortcircuit-parameter
branch
from
2dec5a4 to
950fc05
Compare
EtienneLt
changed the title
EtienneLt
commented
Jun 5, 2024
cpp/pypowsybl-cpp/bindings.cpp
Outdated
| .value("CONFIGURED", pypowsybl::InitialVoltageProfileMode::CONFIGURED, | ||
| "Voltage profile given by the user.") | ||
| .value("PREVIOUS_VALUE", pypowsybl::InitialVoltageProfileMode::PREVIOUS_VALUE, | ||
| "Voltage profile from the loadflow."); |
There was a problem hiding this comment.
@colinepiloquet I just copied what is in powsybl-core
EtienneLt
force-pushed
the
add-new-shortcircuit-parameter
branch
from
950fc05 to
5506b0e
Compare
|
Voltage ranges must also be added, for configured initial voltage map |
It's a parameter in powsybl-core ? |
Yes, also in the short-circuit API I can also try to do it if you want. |
EtienneLt
force-pushed
the
add-new-shortcircuit-parameter
branch
2 times, most recently
from
7477387 to
921e46b
Compare
EtienneLt
force-pushed
the
add-new-shortcircuit-parameter
branch
2 times, most recently
from
c56f59a to
09de88c
Compare
EtienneLt
added
help wanted
| typedef struct voltage_range_struct { | ||
| double minimum_nominal_voltage; | ||
| double maximum_nominal_voltage; | ||
| double voltage; |
There was a problem hiding this comment.
Actually these parameters are not compulsory: either voltage or range coefficient should be given for each [mininum_nominal_voltage, maximum_nominal_voltage].
There was a problem hiding this comment.
in c/cpp double can be null ?
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Tiphaine Mouminous <[email protected]>
Signed-off-by: Tiphaine Mouminous <[email protected]>
Signed-off-by: Tiphaine Mouminous <[email protected]>
colinepiloquet
force-pushed
the
add-new-shortcircuit-parameter
branch
from
efc733f to
2a856a0
Compare
colinepiloquet
changed the title
CONFIGURED initial voltage profile and voltage ranges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: