Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Open Rao integration #868

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] Open Rao integration #868

wants to merge 5 commits into from

Conversation

obrix
Copy link
Member

@obrix obrix commented Oct 18, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@obrix obrix force-pushed the open_rao_integration branch from 8f94e23 to 19661e9 Compare October 21, 2024 08:02
@obrix obrix force-pushed the open_rao_integration branch from bd8bb9f to f0cc2ec Compare November 13, 2024 09:57
@HugoKulesza HugoKulesza self-requested a review November 15, 2024 14:35
@obrix obrix force-pushed the open_rao_integration branch 2 times, most recently from 04bd3b0 to 7e27c35 Compare November 25, 2024 13:00
pypowsybl/rao/impl/__init__.py Outdated Show resolved Hide resolved
pypowsybl/rao/__init__.py Outdated Show resolved Hide resolved
pypowsybl/rao/impl/util.py Show resolved Hide resolved
pypowsybl/rao/impl/rao.py Show resolved Hide resolved
pypowsybl/_pypowsybl.pyi Outdated Show resolved Hide resolved
.github/workflows/dev-ci.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure to understand every change here
Do we add all the ortools libraries of the different platforms in the pom and then only link one here depending on the actual platform ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's exactly what is done here

cpp/pypowsybl-cpp/bindings.cpp Outdated Show resolved Hide resolved
@obrix obrix force-pushed the open_rao_integration branch 2 times, most recently from b139869 to a988138 Compare December 4, 2024 13:44
obrix added 5 commits December 9, 2024 10:32
Signed-off-by: Bertrand Rix <[email protected]>

Display info for mac and windows too.

Signed-off-by: Bertrand Rix <[email protected]>

Restore.

Signed-off-by: Bertrand Rix <[email protected]>

Try correctly exporting native libs.

Signed-off-by: Bertrand Rix <[email protected]>

Add rao python.

Signed-off-by: Bertrand Rix <[email protected]>

Try removing audit to see where is fails next.

Signed-off-by: Bertrand Rix <[email protected]>

Memory view instead of BytesIO directly.

Signed-off-by: Bertrand Rix <[email protected]>

Try excluding problematic lib from audit.

Signed-off-by: Bertrand Rix <[email protected]>

Swap.

Signed-off-by: Bertrand Rix <[email protected]>

verbose.

Signed-off-by: Bertrand Rix <[email protected]>

Check.

Signed-off-by: Bertrand Rix <[email protected]>

Move exclude.

Signed-off-by: Bertrand Rix <[email protected]>

Single plat.

Signed-off-by: Bertrand Rix <[email protected]>

Try downloading compatible jar.

Signed-off-by: Bertrand Rix <[email protected]>

Add dependency for proper order.

Signed-off-by: Bertrand Rix <[email protected]>

Fix.

Signed-off-by: Bertrand Rix <[email protected]>

Avoid extracting in target dir.

Signed-off-by: Bertrand Rix <[email protected]>

Fix audit call.

Signed-off-by: Bertrand Rix <[email protected]>

Add proper result mapping with tests.

Signed-off-by: Bertrand Rix <[email protected]>

Fix typecheck.

Signed-off-by: Bertrand Rix <[email protected]>

Return type.

Signed-off-by: Bertrand Rix <[email protected]>

Test json output as an example and clean.

Signed-off-by: Bertrand Rix <[email protected]>

Clean.

Signed-off-by: Bertrand Rix <[email protected]>

Clean.

Signed-off-by: Bertrand Rix <[email protected]>

Rename test case.

Signed-off-by: Bertrand Rix <[email protected]>

Abstract glsk importers.

Signed-off-by: Bertrand Rix <[email protected]>

Crac and glsk as attributes.

Signed-off-by: Bertrand Rix <[email protected]>

Wrap parameters.

Signed-off-by: Bertrand Rix <[email protected]>

Fix typing.

Signed-off-by: Bertrand Rix <[email protected]>

fix typing.

Signed-off-by: Bertrand Rix <[email protected]>

Again.

Signed-off-by: Bertrand Rix <[email protected]>

Return type mandatory for constructor without parameters.

Signed-off-by: Bertrand Rix <[email protected]>

Use bytes serialization for file serialization and clean.

Signed-off-by: Bertrand Rix <[email protected]>

Clean.

Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>

Try reverting to old image to produce old wheel.

Signed-off-by: Bertrand Rix <[email protected]>

Revert "Try reverting to old image to produce old wheel."

This reverts commit f4465f5.
Signed-off-by: Bertrand Rix <[email protected]>
@obrix obrix force-pushed the open_rao_integration branch from a988138 to c48ca49 Compare December 9, 2024 09:32
Copy link

sonarcloud bot commented Dec 9, 2024

Copy link

sonarcloud bot commented Dec 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants