Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larger form for creating announcements #9753

Merged

Conversation

notbakaneko
Copy link
Collaborator

@notbakaneko notbakaneko commented Jan 16, 2023

Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling I asked about this before and the reply was something around the line it was the design 🤔

@@ -4,19 +4,20 @@
.chat-form {
--input-size: @font-size--title-small-3;

display: flex;
flex-direction: column;
flex: 1;
background: hsl(var(--hsl-b4));

&__button-bar {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bar should probably be get rid of entirely so the margins are uniform

@notbakaneko notbakaneko force-pushed the feature/chat-announcement-form-fill-height branch from 7774776 to 1f4161f Compare January 16, 2023 12:34
@nanaya nanaya enabled auto-merge January 16, 2023 12:45
@nanaya nanaya merged commit 4894bc0 into ppy:master Jan 16, 2023
@notbakaneko notbakaneko deleted the feature/chat-announcement-form-fill-height branch January 17, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants