Send mail notification for announcement messages #9758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
force-pushed
the
feature/chat-announcement-notification-mail
branch
from
0c2686a
to
6be4d7b
Compare
notbakaneko
force-pushed
the
feature/chat-announcement-notification-mail
branch
from
6be4d7b
to
1cb0834
Compare
nanaya
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no options because these are not meant to be disabled; also, possibly why they didn't have a mail option in the first place. (I also vaguely recall some previous discussion about having notification delivery options that require at least one to be enabled, but that's a different issue to solve)
#9741