Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential issues with medal display #30877

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix potential issues with medal display #30877

wants to merge 10 commits into from
+53 −33

Commits on Nov 26, 2024

  1. Ensure DrawableMedal loading doesn't ever block on online resources

    @peppy
    peppy committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    8585327 View commit details
    Browse the repository at this point in the history

  2. Refactor MedalOverlay to be more readable 

    Shouldn't really have any functionality changes, just fixing some old
code that I can't easily parse these days.
    @peppy
    peppy committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d057dc9 View commit details
    Browse the repository at this point in the history

  3. Better control of show/hide of overlay

    @peppy
    peppy committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    672dbe6 View commit details
    Browse the repository at this point in the history

  4. Fix hidden dissmissing logic

    @peppy
    peppy committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e8fae85 View commit details
    Browse the repository at this point in the history

  5. Remove debug logging

    @peppy
    peppy committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    1e6c04e View commit details
    Browse the repository at this point in the history

  6. Revert "Ensure DrawableMedal loading doesn't ever block on online r… 

    …esources"

This reverts commit 8585327.
    @peppy
    peppy committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    98044c1 View commit details
    Browse the repository at this point in the history

  7. Change point of queueing to avoid loading-from-in-queue

    @peppy
    peppy committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    71294c3 View commit details
    Browse the repository at this point in the history

  8. Simplify hide code by moving to common method

    @peppy
    peppy committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    bf29e3a View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Attempt to fix test failures

    @bdach
    bdach committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    b0958c8 View commit details
    Browse the repository at this point in the history

  2. Fix LCA call crashing in actual usage 

    It's not allowed to call `LoadComponentsAsync()` on a background thread:

	https://github.com/ppy/osu-framework/blob/fd64f2f0d47f0ee1aaa596bde1e83e527d610340/osu.Framework/Graphics/Containers/CompositeDrawable.cs#L147

and in this case the event that causes the LCA call is dispatched from a
websocket client, which is not on the update thread, so scheduling is
required.
    @bdach
    bdach committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    c14fe21 View commit details
    Browse the repository at this point in the history