Add setting to allow hold-for-pause to still exist #30878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users have asked for this multiple times since last release. Not sure on the best default value, but I'm going with the stable/classic one, at least for the initial release to avoid needing migrations. In the future we may reconsider this for new users.
smoogipoo
approved these changes
Nov 26, 2024
|
For cases like this I don't really see an alternative. If the community is split on a behaviour and both have valid reasons to exist, then I think providing a setting is the best thing we can do. |
|
I think it's fine to be opinionated. People have somehow been playing stable for 17 years with this "i sometimes hit my escape key" issue. They find a way around it. |
|
The hold part was my proposed direction though. As in I think it's a better default. So finding a middle ground is the best bet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have asked for this multiple times since last release.
Not sure on the best default value, but I'm going with the stable/classic one, at least for the initial release to avoid needing migrations.
In the future we may reconsider this for new users.