Fix hitobjects' samples getting in bad state when changing selection between objects

[peppy]

This was causing state pollution in the new selection. I can't see why this needs to happen when a selection changes to another.

This fixes #30839 and also the same issue happening for the new combo toggle.

Of note, this issue only occurs due to this code having Schedule calls, causing the **reset from a Clear() call to be run after the subsequent Add(newSelection):

osu/osu.Game/Screens/Edit/Compose/Components/EditorSelectionHandler.cs

Lines 300 to 303 in 3ecb3b6

	private void onSelectedItemsChanged(object? sender, NotifyCollectionChangedEventArgs e)
	{
	// Reset the ternary states when the selection is cleared.
	if (e.OldStartingIndex >= 0 && e.NewStartingIndex < 0)

Removing the schedules is also a viable solution:

diff --git a/osu.Game/Screens/Edit/Compose/Components/EditorSelectionHandler.cs b/osu.Game/Screens/Edit/Compose/Components/EditorSelectionHandler.cs
index 78cee2c1cf..b7652af23d 100644
--- a/osu.Game/Screens/Edit/Compose/Components/EditorSelectionHandler.cs
+++ b/osu.Game/Screens/Edit/Compose/Components/EditorSelectionHandler.cs
@@ -258,9 +258,6 @@ private void createStateBindables()
 
         private void resetTernaryStates()
         {
-            if (SelectedItems.Count > 0)
-                return;
-
             SelectionNewComboState.Value = TernaryState.False;
             AutoSelectionBankEnabled.Value = true;
             SelectionAdditionBanksEnabled.Value = true;
@@ -301,9 +298,9 @@ private void onSelectedItemsChanged(object? sender, NotifyCollectionChangedEvent
         {
             // Reset the ternary states when the selection is cleared.
             if (e.OldStartingIndex >= 0 && e.NewStartingIndex < 0)
-                Scheduler.AddOnce(resetTernaryStates);
+                resetTernaryStates();
             else
-                Scheduler.AddOnce(UpdateTernaryStates);
+                UpdateTernaryStates();
         }
 
         private IEnumerable<IList<HitSampleInfo>> enumerateAllSamples(HitObject hitObject)

[cloudrac3r]

I've been using this code change for the last couple of hours and it's been working well for me. I haven't seen any negative side effects. Thank you for the fix!

[bdach]

Removing the schedules is also a viable solution

Schedules date back to ab308d2 so I think I'd rather not touch them.

[bdach]

seems ok if CI passes