Upgrade esbuild-loader and @craco/craco #73
Conversation
|
@Crecket thanks for the pr, it seems that the tests are broken with the new changes, can you please have a look? for the tests, we should probably stop supporting node 16 as it's not LTS anymore and move the ci to run on node 18 + 20 |
|
Removing the loader means it will check for jsx/tsx file extensions to decide which one to use and it was failing on JSX content without a .jsx extension in the example. It does seem nice to let the esbuild-loader handle that behavior over this plugin checking for a tsconfig but I guess we could revert that change and not touch the old behavior as I imagine this would break existing apps and force people to use .jsx over regular .js extensions in their projects Changed the default node version to 20 for the release step / swapped to running only node 16/18/20 for the tests Besides that, I upgraded some other dependencies to fix the builds and added a missing babel dependency that was breaking the typescript example for some reason. |
packages/craco-esbuild/package.json
Outdated
| @@ -9,15 +9,15 @@ | |||
| "src" | |||
| ], | |||
| "peerDependencies": { | |||
| "@craco/craco": "^6.0.0 || ^7.0.0 || ^7.0.0-alpha", | |||
| "@craco/craco": "^^7.0.0 || ^7.0.0-alpha", | |||
There was a problem hiding this comment.
let's remove the alpha option there, if people use the latest version they should upgrade to craco stable
| }, | ||
| "devDependencies": { | ||
| "@craco/craco": "6.4.3", | ||
| "@craco/craco": "7.0.0", |
There was a problem hiding this comment.
let's use the latest craco version here?
|
@Crecket I think the tests are failing because you are using pnpm 8+ and the ci is using pnpm 6 so the generated lockfile is incompatible. |
|
Any chance we can get this in soon? I was looking to open a PR but found that it's something that's in the doing already. I'd also suggest to keep |
|
I'll look into this again this weekend, been away/busy for a bit so haven't had time to fix the last few issues yet |
|
I see CI is passing now, any chance it can get approved? @pradel |
|
Published in 0.6.0 |
Versions were way behind causing issues for our project, alle the examples seem to be working using these versions.
Modified the EsbuildPlugin import as mentioned in the esbuild-loader migration docs and removed the typescript check as the esbuild-loader now does that automatically (See 3.0.0)
Added a requirement for node 16 matching esbuild-loader requirements v3