Update Router and Link type definitions #435
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the type definitions to
Router
andLink
in order to better represent their actual implmentations.The type definitions for the
Link
component inpreact-router
andpreact-router/match
have some ambiguity between each other, which causes problems like #379. The baseLink
type definition is now more restricted to make clear thatactiveClassName
can only be applied to thematch
variant.onClick
is also now omitted as a link prop in order to ensure that theonClick
handler used bypreact-router
is not overriden.The
match
Link
variant can also now take in extra props ofactiveClass
andpath
.