Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signals-react): use isomorphic layout #611

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

Xstoudi
Copy link
Contributor

@Xstoudi Xstoudi commented Oct 8, 2024

Proposal to fix #606

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 9ad0593

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 9ad0593
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6709992b6d980200084c6413
😎 Deploy Preview https://deploy-preview-611--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, mind adding a changeset? Should just need to run pnpm changeset, which will walk you through the process.

@Xstoudi
Copy link
Contributor Author

Xstoudi commented Oct 11, 2024

First time doing that, let me know if it's not alright @rschristian .

@rschristian rschristian merged commit 69185ee into preactjs:main Oct 11, 2024
6 checks passed
@rschristian
Copy link
Member

Thanks! We appreciate you taking the time to both report & fix this.

@github-actions github-actions bot mentioned this pull request Oct 8, 2024
@Xstoudi Xstoudi deleted the fix/use-isomorphic-layout-effect branch October 12, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: useLayoutEffect does nothing on the server
2 participants