Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded_kafka_client_version_to_3.7.1 #279

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adkharat
Copy link

@adkharat adkharat commented Nov 27, 2024

Prevous kafka version = 0.11.0.2
Upgraded Kafka version = 3.7.1

With reference to prestodb/presto PR Fix CVE-2022-34917

Kafka 3.7.1 depricates direct Zookeeper interactions:

  • ZkClient,
  • ZkUtils

Upgrading depricates below AdminUtils methods:

  • AdminUtils.createTopic(),
  • AdminUtils.topicExists()
  • AdminUtils.deleteTopic
  1. Deprecated AdminUtils functions are replaced with AdminClient APIs
  2. Deprecated Zookeeper dependency is replaced with Kafka's AdminClient API.
  3. Encapsulated AdminClient logic in a method KafkaAdminClient to manage lifecycle and reduce boilerplate.
  4. Operations such as topic creation (createTopic) and deletion (deleteTopic) now use AdminClient's createTopics and deleteTopics.

FYI:

kafka.utils.ZkUtils was deprecated since 2.0.0.

2.0.0- > ZKUtils present
2.3.1 -> ZKUtils present
2.4.0 -> ZKUtils removed
2.8.2 -> ZKUtils not present (Version 2.8.2 has some vulnerability)
3.7.1 -> ZKUtils not present

upgraded_kafka_client_version_to_2.8.2

undo commented code

removed zkclient
@adkharat adkharat force-pushed the upgrade_kafka_client_version_cve_2022_34917 branch from 2576948 to a15a170 Compare November 27, 2024 05:58
@adkharat
Copy link
Author

adkharat commented Nov 27, 2024

Build on

gradle -v                                                     
------------------------------------------------------------
Gradle 6.6
------------------------------------------------------------

Build time:   2020-08-10 22:06:19 UTC
Revision:     d119144684a0c301aea027b79857815659e431b9

Kotlin:       1.3.72
Groovy:       2.5.12
Ant:          Apache Ant(TM) version 1.10.8 compiled on May 10 2020
JVM:          1.8.0_422 (Azul Systems, Inc. 25.422-b05)
OS:           Mac OS X 14.4 x86_64

@adkharat adkharat marked this pull request as ready for review November 27, 2024 06:00
@adkharat
Copy link
Author

@imjalpreet can you please review the changes.

@adkharat adkharat changed the title upgraded_kafka_client_version_to_2.8.2 upgraded_kafka_client_version_to_3.7.1 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant