Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Co-Badged Cards Example App #1

Merged
merged 50 commits into from
Feb 20, 2024
Merged

Co-Badged Cards Example App #1

merged 50 commits into from
Feb 20, 2024

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Dec 7, 2023 •
edited
Loading

@jnewc jnewc added the do not merge When there's (external) reason to not merge the PR label Dec 8, 2023
borisprimer
borisprimer approved these changes Dec 11, 2023
View reviewed changes
Copy link

@borisprimer borisprimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Running the app had some issues, but we are on the same page regarding those!

@jnewc jnewc requested a review from NQuinn27 January 3, 2024 11:43
NQuinn27
NQuinn27 reviewed Jan 3, 2024
View reviewed changes
Co-Badged Cards/README.md Outdated Show resolved Hide resolved
@NQuinn27
Copy link

NQuinn27 commented Jan 4, 2024

Looks good, nice work!

jnewc and others added 15 commits January 5, 2024 16:03
@jnewc
Merge remote-tracking branch 'origin/jn/co-badged-cards-example' into…
0f81b93 
… jn/co-badged-cards/workflows
@jnewc
Point at branch for SDK + fix propogation of selected network
6cc8099
@jnewc
Fix scheme name in workflow file
1c5f623
@jnewc
Fix scheme name in workflow matrix
2dd1e06
@jnewc
Merge pull request #2 from primer-io/jn/co-badged-cards/workflows
087bc94 
Add fastlane + github workflow for building example app
@jnewc
Fix selection of card network logic + project layout issue
a29b76f
@jnewc
Update with latest changes to feature branch
ba098a6
@jnewc
Clear selected index of co-badged card when new models are received
06fdabb
@jnewc
Add loading spinner during remote load
2b382f5
@jnewc
Remove available card networks control and logic
4da1b60
@jnewc
Fix loading + validation reloads + error order
1bc605e
@jnewc
Change payment button title + error message
57654f7
@jnewc
Fix state sync issue + fix CB-only not displaying correctly when not …
3198198 
…supported + change grayscale to opacity
@jnewc
Remove debug print
a0628dc
@xevious78
chore: update readme
29b4509
@jnewc jnewc requested review from NQuinn27 and borisprimer February 6, 2024 14:56
@semirp semirp requested a review from psedge February 16, 2024 13:09
psedge
psedge reviewed Feb 16, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
psedge
psedge reviewed Feb 16, 2024
View reviewed changes
LICENSE.md Outdated Show resolved Hide resolved
@jnewc jnewc removed the do not merge When there's (external) reason to not merge the PR label Feb 20, 2024
@jnewc jnewc merged commit 11b628e into main Feb 20, 2024
1 check passed
@jnewc jnewc deleted the jn/co-badged-cards-example branch February 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semirp semirp semirp left review comments

@psedge psedge psedge approved these changes

@NQuinn27 NQuinn27 NQuinn27 approved these changes

@borisprimer borisprimer Awaiting requested review from borisprimer

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jnewc @NQuinn27 @psedge @semirp @borisprimer @xevious78