chore: embed ipay88 SDK

primer-io · Mar 22, 2024 · 8d120b0 · 8d120b0
1 parent 8f6ce6f
commit 8d120b0
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -22,5 +22,5 @@ build-and-publish:
       - if: $CI_COMMIT_TAG
   artifacts:
     paths:
-      - ipay88/build/outputs/aar/
+      - ipay88/build/outputs/
   when: manual
diff --git a/gradle.properties b/gradle.properties
@@ -41,4 +41,4 @@ SONATYPE_HOST=S01
 RELEASE_SIGNING_ENABLED=true
 
 android.defaults.buildfeatures.buildconfig=true
-android.nonFinalResIds=false
+android.nonFinalResIds=false
diff --git a/ipay88/build.gradle b/ipay88/build.gradle
@@ -6,8 +6,9 @@ plugins {
 }
 
 android {
-    namespace 'io.primer.ipay88'
-    compileSdkVersion 34
+    // in order not to crash their SDK, we can use their namespace to correctly find R class
+    namespace 'com.androids.ipay'
+    compileSdk 34
 
     defaultConfig {
         minSdkVersion 21
@@ -38,9 +39,15 @@ android {
     }
 }
 
+tasks.configureEach { task ->
+    if (task.name == "generateReleaseBuildConfig") {
+        task.enabled = false
+    }
+}
+
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
     implementation libs.android.appcompat
 }
 
-apply from: "$rootDir/config/publish.gradle"
+apply from: "$rootDir/config/publish.gradle"
diff --git a/ipay88/proguard-rules.pro b/ipay88/proguard-rules.pro
@@ -54,9 +54,3 @@
     java.lang.Object writeReplace();
     java.lang.Object readResolve();
 }
-
--dontwarn com.androids.ipay.R$drawable
--dontwarn com.androids.ipay.R$id
--dontwarn com.androids.ipay.R$layout
--dontwarn com.androids.ipay.R$string
-
diff --git a/ipay88/src/main/res/values-vi/values-vi.xml b/ipay88/src/main/res/values-vi/values-vi.xml
@@ -24,7 +24,6 @@
     <string name="strBackendPost">Backend Post URL</string>
     <string name="strCancel">Hủy bỏ</string>
     <string name="strCountry">Quốc gia</string>
-    <string name="strCreditCard">Credit Card</string>
     <string name="strCurrency">Đơn vị tiền tệ</string>
     <string name="strErrDesc">ErrDesc</string>
     <string name="strLang">Ngôn ngữ</string>