Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display order shippingMethod if there is no checkoutModules #1017

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

huextrat
Copy link

@huextrat huextrat commented Oct 10, 2024

Description

This change makes it possible to display a shipping method that is available in the clientSession.order.shipping if checkoutModules is nil.

This is useful in cases where only one delivery method is available and therefore no change of shipping method is possible by the user. It's also useful to display the shippingMethod very easily just from the clientSession.

A great use case for this, is a payment without the need of the shippingAddress (so it's no EC). In that case, the shippingMethod price should not change it's already calculated and there is no need to have checkoutModules in that case.

I would have liked to update the example, but it doesn't seem to work with shippingMethod.

This should be non-breaking as checkoutModules always has priority and this change is like a fallback.

Other Notes

  • Other changes that are not specifically related to the intent of the PR

Manual Testing

Add manual testing notes here if applicable, otherwise remove this section

Screenshots

If applicable, otherwise remove this section

Contributor Checklist

  • All status checks have passed prior to code review
  • I have added unit tests to a reasonable level of coverage where suitable
  • I have added UI tests to new user flows, if applicable
  • I have manually tested newly added UX
  • I have open a documentation PR, if applicable

Reviewer Checklist

  • I have verified that a suitable set of automated tests has been added
  • I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR
  • I have verified the documentation PR aligns with this PR, if applicable

Before Merging

  • If introducing a breaking change, I have communicated it internally
  • Any related documentation PRs are ready to merge

Other Stuff

  • You can find out more about our automation checks here
  • Find out more about conventional commits here

@huextrat huextrat requested a review from a team as a code owner October 10, 2024 16:21
@huextrat huextrat force-pushed the feat/shipping-method branch from 9fc614c to b3a12eb Compare October 11, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant