Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jn/vault on authorize #1034

Closed
wants to merge 8 commits into from
Closed

Jn/vault on authorize #1034

wants to merge 8 commits into from

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Oct 24, 2024

Description

Stripe ACH vaulting changes

  • Add support for vaultOnAgreement to debug app client session creation
  • Add new segmented control for selecting vaulting flow
  • Remove non-functional configuration controls
  • Simplify client session creation

Contributor Checklist

  • All status checks have passed prior to code review
  • I have added unit tests to a reasonable level of coverage where suitable
  • I have added UI tests to new user flows, if applicable
  • I have manually tested newly added UX
  • I have open a documentation PR, if applicable

Reviewer Checklist

  • I have verified that a suitable set of automated tests has been added
  • I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR
  • I have verified the documentation PR aligns with this PR, if applicable

Before Merging

  • If introducing a breaking change, I have communicated it internally
  • Any related documentation PRs are ready to merge

Other Stuff

  • You can find out more about our automation checks here
  • Find out more about conventional commits here

Copy link
Contributor

Fails
🚫

Please use a conventional commit title for this PR. See Conventional Commits and SemVer

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏
⚠️ PR is classed as Work in Progress
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against 58a3af3

Copy link

@NQuinn27 NQuinn27 closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants