Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Implement new dismissal mechanisms for Drop-In #1039

Merged
merged 5 commits into from
Nov 13, 2024
Merged

feature: Implement new dismissal mechanisms for Drop-In #1039

merged 5 commits into from
Nov 13, 2024

Conversation

borisprimer
Copy link
Contributor

@borisprimer borisprimer requested a review from NQuinn27 November 7, 2024 10:32
@borisprimer borisprimer self-assigned this Nov 7, 2024
@borisprimer borisprimer requested a review from a team as a code owner November 7, 2024 10:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏

Generated by 🚫 Danger Swift against e984a38

@github-actions GitHub Actions
Copy link
Contributor

Appetize link: https://appetize.io/app/bqjhzta3jrymoixyhgwcsgcewq

@NQuinn27
Copy link
Contributor

Really nice work, tested and works as expected.
Do we have an accompanying docs update?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@NQuinn27 NQuinn27 merged commit e86d2e2 into master Nov 13, 2024
13 of 14 checks passed
@NQuinn27 NQuinn27 deleted the feature/ACC-4442-sheet-dismissal-options branch November 13, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NQuinn27 NQuinn27 NQuinn27 approved these changes

Assignees

@borisprimer borisprimer

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borisprimer @NQuinn27 @BorisNikolic