Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Co-badged Cards on Drop-in #1050

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

borisprimer
Copy link
Contributor

@borisprimer borisprimer commented Nov 21, 2024

Description

CHKT-4371

  • Add support for CoBadged cards on DropIn

Other Notes

  • Before I started working on this, I had a call with Jack where he shared that I should use rawDataManager for this feature; unfortunately, it does not work as expected, so I had to find another way to set the card network for the transaction. Not sure what to do with the RawDataManager.

Manual Testing

I tested manually multiple scenarios, it would be nice to test it as well if you can @NQuinn27

@borisprimer borisprimer self-assigned this Nov 21, 2024
@borisprimer borisprimer requested review from a team as code owners November 21, 2024 10:40
@borisprimer borisprimer marked this pull request as draft November 21, 2024 10:40
guard let self = self else { return }
self.alternativelySelectedCardNetwork = cardNetwork.network
self.rawCardData.cardNetwork = cardNetwork.network
self.rawDataManager?.rawData = self.rawCardData // TODO: (BNI) This does not work for unknown reason
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ TODOs should be resolved ((BNI) This does not work for u...). (todo)

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Warnings
⚠️ > Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review.

Generated by 🚫 Danger Swift against 5a157b4

@borisprimer borisprimer force-pushed the feature/ACC-4371-co-badged-on-dropin branch from e9821b2 to ceca053 Compare December 4, 2024 15:45
@borisprimer borisprimer marked this pull request as ready for review December 5, 2024 18:01
@borisprimer borisprimer force-pushed the feature/ACC-4371-co-badged-on-dropin branch from 4110a2a to 893634f Compare December 5, 2024 18:40
Copy link
Contributor

github-actions bot commented Dec 5, 2024

@borisprimer borisprimer force-pushed the feature/ACC-4371-co-badged-on-dropin branch from 050b0de to 5a157b4 Compare December 9, 2024 11:51
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
60.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants