-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Co-badged Cards on Drop-in #1050
Open
borisprimer
wants to merge
18
commits into
master
Choose a base branch
from
feature/ACC-4371-co-badged-on-dropin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Debug App/Sources/View Controllers/MerchantHeadlessCheckoutRawDataViewController.swift
guard let self = self else { return } | ||
self.alternativelySelectedCardNetwork = cardNetwork.network | ||
self.rawCardData.cardNetwork = cardNetwork.network | ||
self.rawDataManager?.rawData = self.rawCardData // TODO: (BNI) This does not work for unknown reason |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ TODOs should be resolved ((BNI) This does not work for u...). (todo
)
Generated by 🚫 Danger Swift against 5a157b4 |
borisprimer
force-pushed
the
feature/ACC-4371-co-badged-on-dropin
branch
from
December 4, 2024 15:45
e9821b2
to
ceca053
Compare
borisprimer
force-pushed
the
feature/ACC-4371-co-badged-on-dropin
branch
from
December 5, 2024 18:40
4110a2a
to
893634f
Compare
Appetize link: https://appetize.io/app/ju633gutygpu3uqvzhjm2eeehq |
….com/primer-io/primer-sdk-ios into feature/ACC-4371-co-badged-on-dropin
borisprimer
force-pushed
the
feature/ACC-4371-co-badged-on-dropin
branch
from
December 9, 2024 11:51
050b0de
to
5a157b4
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CHKT-4371
Other Notes
Manual Testing
I tested manually multiple scenarios, it would be nice to test it as well if you can @NQuinn27