-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable ACH via Stripe Vaulting flows #1056
Conversation
This reverts commit 018798b.
Generated by 🚫 Danger Swift against e4e1ad5 |
Appetize link: https://appetize.io/app/evzzles3dterujv5mvq4bmdoxq |
This reverts commit 018798b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PCI OK.
* - Returns: A `Promise<Void>` that resolves if the payment is completed successfully, or rejects if there is | ||
* an error during the API call. | ||
*/ | ||
func completePayment(clientToken: DecodedJWTToken, completeUrl: URL) -> Promise<Void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q]: wouldn't it make more sense to send some params to be mapped to request body or maybe request body itself? This seems to be a generic function that creates body for only one use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PCI OK
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PCI OK
Description
ACC-4384
ACC-4461
ACC-4515
Other Notes
Manual Testing
Add manual testing notes here if applicable, otherwise remove this section
Screenshots
If applicable, otherwise remove this section
Contributor Checklist
Reviewer Checklist
Before Merging
Other Stuff