Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump the minimum version and remove all #available statements #758

Merged
merged 8 commits into from
Mar 18, 2024

Conversation

borisprimer
Copy link
Contributor

@borisprimer borisprimer commented Dec 5, 2023

Description

CHKT-1948

  • Bump minimum required versions to iOS 13 and Swift 5 in .podspec and in Package.swift files.
  • Remove #available statements everywhere
  • Breaking changes:
    Well... Yes and no, these changes are indeed breaking but no one will be affected.

Contributor Checklist

  • All status checks have passed prior to code review
  • I have correctly prefixed one of the following conventional commit titles:
    • fix - patch version update

Reviewer Checklist

  • I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR

Before Merging

  • If introducing a breaking change, I have communicated it internally

Other Stuff

  • 3DS PR
  • You can find out more about our automation checks here
  • Find out more about conventional commits here

@borisprimer borisprimer self-assigned this Dec 5, 2023
@borisprimer borisprimer requested a review from a team as a code owner December 5, 2023 15:22
@borisprimer borisprimer requested review from jnewc and NQuinn27 December 5, 2023 15:24
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏
⚠️

Sources/PrimerSDK/Classes/Core/PrimerHeadlessUniversalCheckout/Managers/Payment Method Managers/PrimerHeadlessBanksComponentWrapper.swift#L29 - SwiftLint rule 'type_name' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

⚠️

Sources/PrimerSDK/Classes/Core/PrimerHeadlessUniversalCheckout/Managers/Payment Method Managers/PrimerHeadlessUniversalCheckoutComponentWithRedirectManager.swift#L14 - Generic type name should be between 1 and 20 characters long: 'PrimerHeadlessMainComponent' (generic_type_name)

⚠️

Sources/PrimerSDK/Classes/Core/PrimerHeadlessUniversalCheckout/Managers/Payment Method Managers/PrimerHeadlessUniversalCheckoutComponentWithRedirectManager.swift#L14 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Sources/PrimerSDK/Classes/Core/PrimerHeadlessUniversalCheckout/Managers/Payment Method Managers/PrimerHeadlessUniversalCheckoutComponentWithRedirectManager.swift#L18 - Lines should not have trailing whitespace. (trailing_whitespace)

Generated by 🚫 Danger Swift against 576540b

Copy link
Contributor

github-actions bot commented Dec 5, 2023

@NQuinn27
Copy link
Contributor

NQuinn27 commented Dec 6, 2023

Great work, so good to see this 👏

Question: Should this be a fix: or a feat:, I know we agreed not to make it a breaking change, but did we agree on whether it should be a patch or a minor version bump?

@borisprimer borisprimer changed the title fix: Bump the minimum version and remove all #available statements feat: Bump the minimum version and remove all #available statements Dec 6, 2023
@borisprimer borisprimer force-pushed the bn/ios-version-bump branch 2 times, most recently from a61f88c to 54e8ab9 Compare December 6, 2023 13:57
@borisprimer borisprimer force-pushed the bn/ios-version-bump branch 2 times, most recently from 5abd5d9 to d22631e Compare January 12, 2024 14:13
@borisprimer borisprimer force-pushed the bn/ios-version-bump branch 2 times, most recently from 0687ea2 to 30b8075 Compare January 17, 2024 17:17
Copy link

gitguardian bot commented Mar 4, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9494411 Triggered Base64 Generic High Entropy Secret 9b87779 Debug App/Tests/Unit Tests/Data Models/ApayaTests.swift View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@jnewc jnewc merged commit c003fc7 into master Mar 18, 2024
7 checks passed
@jnewc jnewc deleted the bn/ios-version-bump branch March 18, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants