-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump the minimum version and remove all #available statements #758
Conversation
Generated by 🚫 Danger Swift against 576540b |
7b1841a
to
ca3c1a2
Compare
Appetize link: https://appetize.io/app/akqb2jrlmlxljbdmnr2sjfpn6u |
Great work, so good to see this 👏 Question: Should this be a fix: or a feat:, I know we agreed not to make it a breaking change, but did we agree on whether it should be a patch or a minor version bump? |
ca3c1a2
to
aefcf11
Compare
a61f88c
to
54e8ab9
Compare
54e8ab9
to
c951a70
Compare
c951a70
to
3f26d3b
Compare
5abd5d9
to
d22631e
Compare
0687ea2
to
30b8075
Compare
30b8075
to
79a5226
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9494411 | Triggered | Base64 Generic High Entropy Secret | 9b87779 | Debug App/Tests/Unit Tests/Data Models/ApayaTests.swift | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Description
CHKT-1948
Well... Yes and no, these changes are indeed breaking but no one will be affected.
Contributor Checklist
Reviewer Checklist
Before Merging
Other Stuff