-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the CVV recapture flag available on Headless #828
Draft
borisprimer
wants to merge
22
commits into
master
Choose a base branch
from
bn/make-cvv-recapture-available-on-headless
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Debug App/.swiftlint.yml # Debug App/Sources/Model/CreateClientToken.swift # Debug App/Sources/View Controllers/Merchant Helpers/MerchantHelpers.swift # Debug App/Sources/View Controllers/MerchantSessionAndSettingsViewController.swift # Debug App/Tests/Unit Tests/Mocks.swift # Debug App/Tests/Unit Tests/Mocks/MockPaymentMethodTokenizationViewModel.swift # Debug App/Tests/Unit Tests/Primer/Ideal/BankComponentTests.swift # Sources/PrimerSDK/Classes/Core/3DS/3DSService.swift # Sources/PrimerSDK/Classes/Core/BIN Data/CardValidationService.swift # Sources/PrimerSDK/Classes/Core/PrimerHeadlessUniversalCheckout/Managers/Payment Method Managers/CardComponentsManager.swift # Sources/PrimerSDK/Classes/Core/PrimerHeadlessUniversalCheckout/PrimerHeadlessUniversalCheckout.swift # Sources/PrimerSDK/Classes/Data Models/CardButtonViewModel.swift # Sources/PrimerSDK/Classes/Data Models/ClientSession.swift # Sources/PrimerSDK/Classes/Error Handler/PrimerError.swift # Sources/PrimerSDK/Classes/Error Handler/PrimerValidationError.swift # Sources/PrimerSDK/Classes/Extensions & Utilities/AnyDecodable.swift # Sources/PrimerSDK/Classes/PCI/Checkout Components/PrimerRawCardDataRedirectTokenizationBuilder.swift # Sources/PrimerSDK/Classes/User Interface/Root/PrimerRootViewController.swift # Sources/PrimerSDK/Classes/User Interface/Root/PrimerUniversalCheckoutViewController.swift
Generated by 🚫 Danger Swift against c838977 |
borisprimer
force-pushed
the
bn/cvv-recapture-drop-in
branch
from
April 5, 2024 09:05
19933e1
to
02dc222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make the CVV Recapture backend flag available for merchants who are using Headless as well. This is a proposal of how we could do it.
The option is available in
primerHeadlessUniversalCheckoutDidLoadAvailablePaymentMethods
delegate method.RFC for more information.
WDYT?