Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test matrix workflow for optional SDKs #888

Merged
merged 49 commits into from
Jun 5, 2024

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented May 30, 2024

Description

This PR modifies the existing github workflows to allow testing and coverage reporting for optional SDK as they function when integrated with the core SDK

Includes:

  • Matrix job for three optional SDKs (3DS, Klarna, NolPay)
  • Separate job for debug app tests (coverage not reported)
  • Collation of coverage reports and reporting to sonar
  • Separate Package.*.swift files for testing specific optional SDKs (used by GH workflows)
  • Package.Development.swift for working on and testing all optional SDKs (for local use)

Other Notes

  • iPay88 is currently not included due to issues with the way the vendor framework is packaged.

Contributor Checklist

  • All status checks have passed prior to code review
  • I have added unit tests to a reasonable level of coverage where suitable
  • I have added UI tests to new user flows, if applicable
  • I have manually tested newly added UX
  • I have open a documentation PR, if applicable

Reviewer Checklist

  • I have verified that a suitable set of automated tests has been added
  • I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR
  • I have verified the documentation PR aligns with this PR, if applicable

Before Merging

  • If introducing a breaking change, I have communicated it internally
  • Any related documentation PRs are ready to merge

Other Stuff

  • You can find out more about our automation checks here
  • Find out more about conventional commits here

@jnewc jnewc requested a review from a team as a code owner May 30, 2024 20:02
Copy link
Contributor

github-actions bot commented May 30, 2024

Warnings
⚠️ > Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review.
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.

Generated by 🚫 Danger Swift against 227e0e2

Copy link
Contributor

@jnewc jnewc force-pushed the jn/optional-sdk-matrix-tests branch from dd32e52 to 01c27c7 Compare May 31, 2024 11:38
@jnewc jnewc force-pushed the jn/optional-sdk-matrix-tests branch from fdf1ddf to 973e40e Compare June 4, 2024 13:17
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jnewc jnewc merged commit 43d1ff8 into master Jun 5, 2024
13 checks passed
@jnewc jnewc deleted the jn/optional-sdk-matrix-tests branch June 5, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants