Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react native environment to 0.72.3 #175

Merged
merged 34 commits into from
Sep 12, 2023
Merged

Upgrade react native environment to 0.72.3 #175

merged 34 commits into from
Sep 12, 2023

Conversation

jnewc
Copy link
Contributor

@jnewc jnewc commented Sep 11, 2023

WIP

@jnewc jnewc added the wip label Sep 11, 2023
@jnewc
Copy link
Contributor Author

jnewc commented Sep 11, 2023

The plan is to fully update workflows + fastlane with #147 from @semirp after this has been merged

@jnewc
Copy link
Contributor Author

jnewc commented Sep 12, 2023

@semirp the upgrade required changing the some of the event listener functions to use subscriptions instead of removing via the emitter. However, these methods (i.e. removeListener across several files) are not exposed via the public interface currently, so there's no breaking change here 👍

@jnewc jnewc merged commit 21cee3a into master Sep 12, 2023
@jnewc jnewc deleted the jn/react-native-upgrade-0.72.3 branch September 12, 2023 13:04
@jnewc jnewc removed the wip label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semirp semirp semirp approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnewc @semirp