Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to dismiss the drop in #249

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Add options to dismiss the drop in #249

wants to merge 6 commits into from

Conversation

borisprimer
Copy link
Contributor

@borisprimer borisprimer commented Nov 13, 2024 •
edited
Loading

Implement a new DismissalMechanism for dismissing the DropIn UI.

Draft because it waits for the Android release on native side.

@borisprimer borisprimer self-assigned this Nov 13, 2024
@borisprimer borisprimer requested a review from a team as a code owner November 13, 2024 16:04
@borisprimer borisprimer marked this pull request as draft November 13, 2024 16:04
@BorisNikolic
Merge branch 'master' into bn/ACC-4442-dismissal-mechanism
a36b6aa 
# Conflicts:
#	packages/sdk/android/build.gradle
#	packages/sdk/package.json
#	packages/sdk/primer-io-react-native.podspec
@BorisNikolic
Fix minor bug
77a1ce3
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Appetize iOS link: https://appetize.io/app/lfztcolrdmxze6igogst5ker6m

@NQuinn27
Copy link
Contributor

@FlaviuExtPrimer will the Android counterpart to this be released in the next release? The iOS underlying code is there (@BorisNikolic can confirm), but we should merge this only when both platforms are aligned.

@FlaviuExtPrimer
Copy link
Contributor

@FlaviuExtPrimer will the Android counterpart to this be released in the next release? The iOS underlying code is there (@BorisNikolic can confirm), but we should merge this only when both platforms are aligned.

@NQuinn27, @borisprimer, this is still in progress on the native Android SDK, so this RN wrapper shouldn't be made available in the RN release we plan on making today.

@FlaviuExtPrimer
Copy link
Contributor

@borisprimer, I've updated this branch with a change to the IPrimerUIOptions object to support an array of strings for dismiss options, along with a fix for the Android wrapper. Also, I've merged changes from master, please check if it is fine on your side.

@FlaviuExtPrimer
Copy link
Contributor

@borisprimer, I've added the documentation in this PR: https://github.com/primer-io/primer-docs/pull/977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NQuinn27 NQuinn27 Awaiting requested review from NQuinn27

@semirp semirp Awaiting requested review from semirp

@dariusparteneprimer dariusparteneprimer Awaiting requested review from dariusparteneprimer

At least 1 approving review is required to merge this pull request.

Assignees

@borisprimer borisprimer

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@borisprimer @NQuinn27 @FlaviuExtPrimer @BorisNikolic