Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-36298 - Exposing Internal Event API Externally #262

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Adam0Brien
Copy link
Contributor

@Adam0Brien Adam0Brien commented Dec 2, 2024

PR Template:

Describe your changes

  • Exposes eventing api structs for use in /api/structs.go

Once merged structs can be imported to other go projects:

import (
        "fmt"
	api "github.com/inventory-api/api"
)

func main() {
	
	resource := api.ResourceData{
		Metadata: api.ResourceMetadata{
			ResourceType: "k8s_cluster",
			WorkspaceId:  "workspace1",
			OrgId:        "org-1",
		},
	}
	
	fmt.Printf("Resource Data: %+v\n", resource)
	
}

Ticket reference (if applicable)

Fixes #RHCLOUD-36298

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

@Adam0Brien Adam0Brien changed the title Move eventing outside of internal RHCLOUD-36298 - Exposing Internal Event API Externally Dec 2, 2024
@Adam0Brien Adam0Brien force-pushed the expose-eventing branch 2 times, most recently from 75affd5 to 630be60 Compare December 2, 2024 11:04
@Adam0Brien Adam0Brien marked this pull request as ready for review December 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant