Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matched a couple JSystem TUs #218

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Conversation

LagoLunatic
Copy link
Contributor

copied some JASSeqParser matches from TWW back to here since a number of the remaining issues were solved by inlines from the debug maps. (note that I didn't bother copying the inlines that weren't necessary for a match, but there are a lot more of those you can take if you want the code to be more readable.)

also fixed J2DPicture's weak function ordering

Copy link
Member

@EpochFlame EpochFlame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Easier to read and understand thanks to the inline usage. Appreciate the PR, thanks so much! It'll be great to have JSystem complete across all decomps.

@EpochFlame EpochFlame merged commit f3b403b into projectPiki:main Sep 8, 2024
4 checks passed
@LagoLunatic LagoLunatic deleted the jsystem branch September 8, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants