Merge pull request #192 from projectsyn/bug/typed-nil-vault-client

Fix typed nil assignment
projectsyn · Aug 10, 2021 · 02bf041 · 02bf041
2 parents ab5af1a + d0596c1
commit 02bf041
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/vault/client.go b/vault/client.go
@@ -53,11 +53,13 @@ func NewClient(deletionPolicy synv1alpha1.DeletionPolicy, log logr.Logger) (Vaul
 		return instanceClient, nil
 	}
 
-	var err error
-	instanceClient, err = newBankVaultClient(deletionPolicy, log)
-
-	return instanceClient, err
+	c, err := newBankVaultClient(deletionPolicy, log)
+	if err != nil {
+		return nil, err
+	}
+	instanceClient = c
 
+	return instanceClient, nil
 }
 
 // SetCustomClient is used if a custom client needs to be used. Currently only