-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NF: Adding field seperator selection in output #566
base: main
Are you sure you want to change the base?
Conversation
Adding to ExperimentHandler a field separator property, which allows output to include field separators other than comma (e.g., TSV format).
Fixed type in this._field_separator
Passing parameters correctly to .sheet_to_csv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly I like your thinking, but I think it's better for cross-language parity if the delim is an input when creating the experiment handler rather than being in expInfo. Being in expInfo means that it will appear in the data file and (if we don't otherwise handle it) the participant info dialog.
What if instead of looking for field_separator
in extraInfo
, ExperimentHandler simply had an attribute .field_separator
(like what you extract to here) which defaults to ","
if not otherwise set? Then in the compiled code from the app we can do psychoJS.experiment.field_separator = %(Data file delimiter)s
Thanks for the feedback @TEParsons, i think the current changes should do it and not putting it in expInfo is more elegant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following this feature request, this pull request will allow passing the data delimiter selected on PsychoPy, when converting the experiment to PsychoJS.
Note that the changes are not implemented yet on the PsychoPy end, and
psychoJS.ExperimentHandler._field_separator
is an undefined property. Thus the expected behavior is that the default (',') field separator will be selected.