Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add land, ocean and coast color to lsm #17

Merged
merged 6 commits into from
May 11, 2020
Merged

add land, ocean and coast color to lsm #17

merged 6 commits into from
May 11, 2020

Conversation

Chilipp
Copy link
Member

@Chilipp Chilipp commented May 10, 2020

This PR changes the value of the lsm formatoption to a dictionary. Old values are, however, still supported.

In this PR, we additionally add widgets for the psyplot-GUI for the following formatoptions, lsm, xgrid and ygrid (see #1).

linked to psyplot/psy-view#26

  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Fully documented, including CHANGELOG.rst for all changes

This commit changes the value of the lsm formatoption to a dictionary. Old values are, however, still supported.

We additionally add a widget for the psyplot GUI.
@Chilipp Chilipp added the new feature Request for adding a new feature to the package label May 10, 2020
@Chilipp Chilipp self-assigned this May 10, 2020
@Chilipp Chilipp closed this May 10, 2020
@Chilipp Chilipp reopened this May 10, 2020
@Chilipp Chilipp merged commit 1f51585 into psyplot:master May 11, 2020
Chilipp added a commit to psyplot/psy-view that referenced this pull request May 17, 2020
to account for the fact that lsm is now a dict
see psyplot/psy-maps#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for adding a new feature to the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant