Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation for Windows installation #755

Open
wants to merge 9 commits into
base: bookworm
Choose a base branch
from
Open

Preparation for Windows installation #755

wants to merge 9 commits into from

Conversation

tuomasjjrasanen
Copy link
Contributor

@tuomasjjrasanen tuomasjjrasanen commented Oct 20, 2024 •
edited
Loading

This PR includes:

  • lot of refactoring for puavo-reset-windows to make the beef change simpler
  • new optional command line argument (target Windows partition) for puavo-reset-windows

I recommend reviewing this commit byt commit.

@tuomasjjrasanen tuomasjjrasanen self-assigned this Oct 20, 2024
@tuomasjjrasanen tuomasjjrasanen linked an issue Oct 20, 2024 that may be closed by this pull request
Installing dualboot Windows via wim images? #719
Open
@tuomasjjrasanen tuomasjjrasanen force-pushed the puavo-reset-windows-prepare-for-installation-use branch from c27e53e to 10dade6 Compare November 16, 2024 07:42
@tuomasjjrasanen tuomasjjrasanen force-pushed the puavo-reset-windows-prepare-for-installation-use branch from 10dade6 to 2d75bb6 Compare November 27, 2024 17:58
@tuomasjjrasanen
puavo-reset-windows: [refactor] move usage to the top
6016404 
Usage and comments are merged, all win.
@tuomasjjrasanen
puavo-reset-windows: [refactor] rename win_primary_partition => win_c…
7972f17 
…_partition

Because that's what it actually is. Primary is just a partition type,
it does not define it's semantics. Microsoft itself calls this
partition Local Disk (C:) Partition[1].

1: https://learn.microsoft.com/en-us/windows-server/storage/disk-management/overview-of-disk-management
@tuomasjjrasanen
puavo-reset-windows: [refactor] rename reset_win() => install_win()
ab4536f 
Because the function installs new Windows on a given partition from
WIM image. Reseting is the main process, installation is a
sub-process.
@tuomasjjrasanen
puavo-reset-windows: [refactor] split reset_all_wins() to reset_win()…
5232df7 
… and reset_all_wins()
@tuomasjjrasanen
puavo-reset-windows: [refactor] prefix global variables with g_
9078c44
@tuomasjjrasanen
puavo-reset-windows: add optional command line argument, target parti…
31155c5 
…tion
@tuomasjjrasanen
puavo-reset-windows: [refactor] fix indentation
7f60aa2
@tuomasjjrasanen
puavo-reset-windows: [refactor] fix not-well defined construct
59ef394
@tuomasjjrasanen
puavo-reset-windows: [refactor] remove unused local definition
0b7a47a
@tuomasjjrasanen tuomasjjrasanen force-pushed the puavo-reset-windows-prepare-for-installation-use branch from 2d75bb6 to 0b7a47a Compare December 6, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juhaerk juhaerk Awaiting requested review from juhaerk

Assignees

@tuomasjjrasanen tuomasjjrasanen

Labels
Bookworm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installing dualboot Windows via wim images?
1 participant
@tuomasjjrasanen