Correctly handle TX power status codes > 128

zigbeefordomoticz/Domoticz-Zigbee#1045 (comment)
puddly · Feb 10, 2022 · 06294f9 · 06294f9
1 parent ae74701
commit 06294f9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/tests/application/test_startup.py b/tests/application/test_startup.py
@@ -178,7 +178,9 @@ async def test_tx_power(device, succeed, make_application):
             set_tx_power = znp_server.reply_once_to(
                 request=c.SYS.SetTxPower.Req(TXPower=19),
                 responses=[
-                    c.SYS.SetTxPower.Rsp(StatusOrPower=t.Status.INVALID_PARAMETER)
+                    c.SYS.SetTxPower.Rsp(
+                        StatusOrPower=t.Status.MAC_INVALID_PARAMETER - 0xFF - 1
+                    )
                 ],
             )
     else:

diff --git a/zigpy_znp/zigbee/application.py b/zigpy_znp/zigbee/application.py
@@ -327,7 +327,7 @@ async def set_tx_power(self, dbm: int) -> None:
         if self._znp.version >= 3.30 and rsp.StatusOrPower != t.Status.SUCCESS:
             # Z-Stack 3's response indicates success or failure
             raise InvalidCommandResponse(
-                f"Failed to set TX power: {t.Status(rsp.StatusOrPower)!r}", rsp
+                f"Failed to set TX power: {t.Status(rsp.StatusOrPower & 0xFF)!r}", rsp
             )
         elif self._znp.version < 3.30 and rsp.StatusOrPower != dbm:
             # Old Z-Stack releases used the response status field to indicate the power