Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fuzzaldrin algorithm (ported to C++) as a possible choice #2

Merged
merged 12 commits into from
Nov 23, 2023

Conversation

mauricioszabo
Copy link

New option of API:

matcher.match('tiatd', {algorithm: 'fuzzaldrin'})

@confused-Techie
Copy link
Member

These changes look super solid, and love to see new tests added for it.

Although does make me slightly nervous to not have any testing strategy on this package to confirm that the old and new tests are still happy on every supported platform.

So I'll add a light approval missing that, as I'm assuming tests are passing for you locally, but would be much more happy to provide a proper approval if we maybe added an action to test on every supported platform here, like we do other tests

@mauricioszabo
Copy link
Author

Wait, you're right: we don't have tests added to this repo!

I'll add them - I ran the tests locally, and they all passed indeed.

@mauricioszabo
Copy link
Author

Done, testing is activated - and they indeed pass!

(That was easy - honestly, one of the first times I got it working in under than 10 minutes!)

@mauricioszabo mauricioszabo merged commit 130c1c8 into master Nov 23, 2023
1 check passed
@mauricioszabo mauricioszabo deleted the different-scoring-algorithm branch November 23, 2023 18:23
@confused-Techie
Copy link
Member

@mauricioszabo Thanks a ton for addressing my feedback, love to see it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants