-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fuzzaldrin algorithm (ported to C++) as a possible choice #2
Conversation
These changes look super solid, and love to see new tests added for it. Although does make me slightly nervous to not have any testing strategy on this package to confirm that the old and new tests are still happy on every supported platform. So I'll add a light approval missing that, as I'm assuming tests are passing for you locally, but would be much more happy to provide a proper approval if we maybe added an action to test on every supported platform here, like we do other tests |
Wait, you're right: we don't have tests added to this repo! I'll add them - I ran the tests locally, and they all passed indeed. |
Done, testing is activated - and they indeed pass! (That was easy - honestly, one of the first times I got it working in under than 10 minutes!) |
@mauricioszabo Thanks a ton for addressing my feedback, love to see it! |
New option of API: