deps: Use caret ^ semver for nan #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think it's a good trade-off to pin an exact version of nan. It basically never has problems, but with new versions of NodeJS and Electron coming out all the time, bumping nan in your direct/indirect dependencies is frequently quite helpful. Dealing with exact pinned version is much more laborious than just refreshing your lockfile, so caret ^ semver is the way to go, IMO.
confused-Techie
approved these changes
Dec 2, 2023
|
Thanks for review! Merging now. |
DeeDeeG
changed the title
|
Just noticed the typo in the PR title/merge commit message. 🥲 Oh, well. (The typo is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
Adds
^(caret semver) when specifying thenandependency.Motivation:
Allows later upgrades within the same major versions of
nan, without coming back to modify this package'spackage.jsonfile and then bumping this package's version in any/all consumers of this package.Context:
This is a follow-up to #1, which removed the caret
^semver in specifying thenandependency inpackage.json.Rationale:
I don't think it's a good trade-off to pin an exact version of
nan.I've never had a problem updating to a newer version of
nan(no point in pinning an exact version), but with new versions of NodeJS and Electron coming out all the time, bumpingnanin our direct/indirect dependencies is frequently quite helpful (lots of reasons to upgrade frequently, caret^semver comes in handy for this).Dealing with exact pinned version is much more laborious than just refreshing your lockfile, so caret
^semver is the way to go fornan, IMO.Also helps optimize the deduplication of different
nanversions, not thatnanis a very heavy dependency if I recall correctly. Wider/more-permissive semver ranges fornanallow one version ofnanto satisfy the requirements of more packages.