#775 - Explicitly resolve deferred values #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Puppet Agent v8 onwards, a deferred value needs to be explicitly resolved.
fetzerms
requested review from
a team,
b4ldr,
bastelfreak,
ekohl and
smortex
as code owners
|
|
|
Failed unit tests seems transient. Closing and re-opening to trigger a new run. |
|
@smortex - As the build is green now, do we think we can merge this? I think unit tests are not possible/required for this change. But if they are, I'm happy to be guided on what to test :-) |
|
That seems good to me. There is no "policy" AFAIC for external contributors like me and other folks that where added as reviewers, but I would prefer to see a review/approval by someone from @puppetlabs since they own the project. |
joshcooper
approved these changes
Nov 28, 2023
bastelfreak
approved these changes
Nov 28, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Puppet Agent v8 onwards, a deferred value needs to be explicitly resolved.
Summary
This adds explicitly resolving of deferred values. See #775
If that fix is suitable (works for me), I'll be happy to add Spec and acceptance tests for deferred values.
Additional Context
I don't know of the root cause. Seems Puppet Agent v8 is doing things differently than <=v7
Related Issues (if any)
#775
Checklist
puppet apply)