Support refreshonly flag #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Originally submitted as garethr/garethr-docker#653 as a partial fix for garethr/garethr-docker#687. |
Allow for the refreshonly flag to be passed through to the underlying exec resource. This allows for Docker::Exec resources to be defined to only run when notified, which allows for construction of manifests that can check whether updated configuration made available to running containers (provided they are using directory mount binds) are valid before triggering a service restart. Use case for this is to test generated nginx configuration for the running nginx container using a Docker::Exec call that is notified by the file resource and in turn will notify the service resource to restart.
electrofelix
force-pushed
the
refreshonly-support
branch
from
7226850 to
7a9f83d
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for the refreshonly flag to be passed through to the underlying
exec resource.
This allows for Docker::Exec resources to be defined to only run when
notified, which allows for construction of manifests that can check
whether updated configuration made available to running containers
(provided they are using directory mount binds) are valid before
triggering a service restart.
Use case for this is to test generated nginx configuration for the
running nginx container using a Docker::Exec call that is notified by
the file resource and in turn will notify the service resource to
restart.