Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require rspec-puppet 5.x #470

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Require rspec-puppet 5.x #470

merged 1 commit into from
Sep 6, 2024

Conversation

bastelfreak
Copy link
Collaborator

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@bastelfreak bastelfreak requested a review from a team as a code owner September 6, 2024 09:16
bastelfreak added a commit to bastelfreak/puppet-example that referenced this pull request Sep 6, 2024
@bastelfreak bastelfreak changed the title Allow rspec-puppet 5 Allow rspec-puppet 5.x Sep 6, 2024
@bastelfreak bastelfreak changed the title Allow rspec-puppet 5.x Require rspec-puppet 5.x Sep 6, 2024
@bastelfreak
Copy link
Collaborator Author

I tested this for Vox Pupuli and it's working fine for us: voxpupuli/puppet-example#73

@pmcmaw pmcmaw merged commit 0603109 into puppetlabs:main Sep 6, 2024
7 of 8 checks passed
@pmcmaw pmcmaw added the feature label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants