Update CMakeLists.txt to allow FetchContent to work #5

Serinox · 2022-05-13T03:30:38Z

When trying to use this library with CMake's FetchContent command like so:

set(BUILD_EXAMPLES OFF)
set(BUILD_TESTING OFF)
FetchContent_Declare(
        MyGAL
        GIT_REPOSITORY https://github.com/pvigier/MyGAL
        GIT_SHALLOW TRUE
)
FetchContent_MakeAvailable(MyGAL)

I ran into a build issue where the configure_package_config_file was looking for MyGALConfig.cmake.in inside my project instead of the _deps/mygal-src folder that the FetchContent command downloads everything into. Swapping from CMAKE_SOURCE_DIR which is the the top level source directory to CMAKE_CURRENT_LIST_DIR which is the directory of the currently parsed CMakeLists.txt file should resolve it for standard builds and FetchContent builds.

Also let me know if there is an issue with this PR as I've not used GitHub's pull request system enough to be confident I have it correct.

make it so the build works when getting this code through CMake's FetchContent command. The previous usage of CMAKE_SOURCE_DIR instead of CMAKE_CURRENT_LIST_DIR caused a build error because it would look for the MyGALConfig.cmake.in inside of your project instead of the _deps/mygal-src/ folder setup by the FetchContent command

fix a few more instances of CMAKE_SOURCE_DIR that were causing problems.

Serinox changed the title ~~Update CMakeLists.txt~~ Update CMakeLists.txt to allow FetchContent to work May 13, 2022

Update CMakeLists.txt

3744c48

fix a few more instances of CMAKE_SOURCE_DIR that were causing problems.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CMakeLists.txt to allow FetchContent to work #5

Update CMakeLists.txt to allow FetchContent to work #5

Serinox commented May 13, 2022

Update CMakeLists.txt to allow FetchContent to work #5

Are you sure you want to change the base?

Update CMakeLists.txt to allow FetchContent to work #5

Conversation

Serinox commented May 13, 2022