Staging #4805
Merged
Staging #4805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Beth Pan <[email protected]> Co-authored-by: Gleb Khmyznikov <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Mara'ah Lee <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <[email protected]> Co-authored-by: Justin Willis (HE / HIM) <[email protected]> Co-authored-by: Zach Teutsch <[email protected]> Co-authored-by: vipul-bhojwani <[email protected]> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Federico Navarrete <[email protected]> Co-authored-by: Toby Liu <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Jonas Thelemann <[email protected]> Co-authored-by: Siraj Chokshi <[email protected]> Co-authored-by: Thomas Peißl <[email protected]> Co-authored-by: Migush <[email protected]> Co-authored-by: Abdullhakim Sami Alshanqity <[email protected]> Co-authored-by: mecmep <[email protected]> Co-authored-by: Joel Limberg <[email protected]>
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Gleb Khmyznikov <[email protected]>
The explanation of --viteArgs flag has been repeated with a slightly different wording which is now removed ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> Documentation content changes <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Currently the --viteArgs section is duplicated twice with just slight different wording ## Describe the new behavior? Removed duplicated section at the end which makes the page concise ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Justin Willis <[email protected]> Co-authored-by: Beth Pan <[email protected]> Co-authored-by: Gleb Khmyznikov <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Mara'ah Lee <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <[email protected]> Co-authored-by: Justin Willis (HE / HIM) <[email protected]> Co-authored-by: Zach Teutsch <[email protected]> Co-authored-by: vipul-bhojwani <[email protected]> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Federico Navarrete <[email protected]> Co-authored-by: Toby Liu <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Jonas Thelemann <[email protected]> Co-authored-by: Siraj Chokshi <[email protected]> Co-authored-by: Thomas Peißl <[email protected]> Co-authored-by: Migush <[email protected]> Co-authored-by: Abdullhakim Sami Alshanqity <[email protected]> Co-authored-by: mecmep <[email protected]> Co-authored-by: Joel Limberg <[email protected]>
Co-authored-by: Maicon Carraro <[email protected]>
fixes #4750 fixes #4749 fixes #4754 ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> Other... Please describe: Accessibility fixes Also added typescript as a dependency to fix a build issue with npm start + updated shoelace to the latest version ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
No opened issue, it was reported in discord: https://discord.com/channels/930156205542883409/1276973525546172478/1277006937396875497 ## PR Type <!-- Please uncomment one ore more that apply to this PR --> - Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Existing app-file-input has no style which creates confusion with text elements, some elements are using class to specify variants instead of using the actual variant attribute.  ## Describe the new behavior? Changes: - Updated app-file-input to use `sl-button` and variant **secondary** which seems a good fit for this situation. - Removed a cursor pointer styling that was misleading because of element's width - Updated primary button to fit the primary theme color.  ## PR Checklist - [X] Test: run `npm run test` and ensure that all tests pass - [X] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [X] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Justin Willis <[email protected]> Co-authored-by: Beth Pan <[email protected]> Co-authored-by: Gleb Khmyznikov <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Mara'ah Lee <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <[email protected]> Co-authored-by: Justin Willis (HE / HIM) <[email protected]> Co-authored-by: Zach Teutsch <[email protected]> Co-authored-by: vipul-bhojwani <[email protected]> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Federico Navarrete <[email protected]> Co-authored-by: Toby Liu <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Jonas Thelemann <[email protected]> Co-authored-by: Siraj Chokshi <[email protected]> Co-authored-by: Thomas Peißl <[email protected]> Co-authored-by: Migush <[email protected]> Co-authored-by: Abdullhakim Sami Alshanqity <[email protected]> Co-authored-by: mecmep <[email protected]> Co-authored-by: Joel Limberg <[email protected]> Co-authored-by: Pratik-k <[email protected]>
fixes #4743 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> When the input was autofilled, the color was a bright blue that did not have good contrast. ## Describe the new behavior? It now uses our standard input color. ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
|
Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #[issue number]
PR Type
Describe the current behavior?
Describe the new behavior?
PR Checklist
npm run testand ensure that all tests passAdditional Information