feat: improve sdkmanager install for build tools and platforms #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was trying to reproduce the intermittent issue using the existing version (build tools v33) and my approach was trying concurrent requests before it has installed the correct build-tools/platforms, and it corrupted the environment The chances to happen are low because it needs to be a new container, but this PR will prevent this anyway. Still investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A new container based on this image is going to have no platforms and outdated version of build-tools, example:
Above red line is the initial files/folders before any request, and below red line is once you request to build a new app, its going to download and install the required versions for the latest bubblewrap. See it has 2 different build tools, the v33 that is installed because of this Dockerfile, and the v34 required for the bubblewrap + platforms during execution time.
Intermittent bug
In PWABuilder there is one intermittent issue causing the request to fail because of
Failed to find target with hash string 'android-35'(see)I don't have context if it's related to an old container running, or if it can be related to a new container failing to download and install, so this PR also includes a possible fix for this.
New result
Again above red line is a new container without request and below is after request.
It should speed up the success rate and performance since it doesn't need to install at execution time for a new container.