fix performance regression for JSON tagged union #1552
Merged
+58
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Nov 21, 2024
| @@ -117,44 +117,6 @@ fn union_serialize<S>( | |||
| Ok(None) | |||
| } | |||
|
|
|||
| fn tagged_union_serialize<S>( | |||
There was a problem hiding this comment.
Moved down, to be a method on TaggedUnionSerializer.
| // If extra.check is SerCheck::None, we're in a top-level union. We should thus raise | ||
| // this warning | ||
| let value_str = truncate_safe_repr(value, None); | ||
| extra.warnings.custom_warning( |
There was a problem hiding this comment.
Moved this warning here from get_discriminator_value, seemed more correct as the other warnings are raised in union_serialize.
| mut selector: impl FnMut(&CombinedSerializer, &Extra) -> PyResult<S>, | ||
| extra: &Extra, | ||
| ) -> PyResult<Option<S>> { | ||
| if let Some(tag) = self.get_discriminator_value(value) { |
There was a problem hiding this comment.
Makes sure that we always try to get the tag by having the method call here 😉
CodSpeed Performance ReportMerging #1552 will not alter performanceComparing Summary
|
sydney-runkle
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes unintentional performance loss from #1538
At the same time I thought I would compress this down a bit further.
Related issue number
N/A
Checklist
pydantic-core(except for expected changes)