Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings source for AWS Secrets Manager #176

Closed
wants to merge 1 commit into from
Closed

Add settings source for AWS Secrets Manager #176

wants to merge 1 commit into from

Conversation

rishacha
Copy link

@rishacha rishacha commented Oct 8, 2023

What does this PR do?

This commit adds a SettingsSource for AWS Secrets Manager

Implements #175

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e529615) 97.45% compared to head (5b37e2e) 96.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   97.45%   96.58%   -0.87%     
==========================================
  Files           5        5              
  Lines         314      322       +8     
  Branches       69       70       +1     
==========================================
+ Hits          306      311       +5     
- Misses          6        9       +3     
  Partials        2        2              
Files Coverage Δ
pydantic_settings/sources.py 96.66% <62.50%> (-1.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rishacha rishacha closed this by deleting the head repository Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant