-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve nested code fence line numbering #182
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 5 5
Lines 314 314
Branches 69 69
=======================================
Hits 306 306
Misses 6 6
Partials 2 2 ☔ View full report in Codecov by Sentry. |
For context, see pydantic/pydantic#7950 |
Thanks @johndutchover for this patch. As I mentioned in the comments I don't see any change in the rendered docs. You can also build
which is your branch. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@hramezani Turns out that "extra" newlines between code blocks and the numbered list items was preventing desired numbering sequence (1. .... 2. ...) when building docs. LGTM now! |
Thanks @johndutchover |
Summary of changes
index.md
Correct line numbering by adding by adding one backquote (min four) to code fences and indent code fences with three spaces
Intent nested code fences using three spaces
Fixes list items numbering: fenced code blocks, within item lists:
Remove[renumbered]duplicateline: