-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/instance level source customization #350
Conversation
Added ``tests`` under optional depends because it is annoying to run ``pytest`` multiple times to know which depends must be installed.
Thanks @acederberg for this PR. please:
|
Added ``_settings_customize_instance`` to ``__init__``.
``_settings_customize_instance``.
@hramezani I added tests and docs, it looks like everything is good to go. I notice that the tests fail for |
@hramezani This should work. Is there anything else I ought to do? |
Thanks @acederberg for the update. I need to check it more with the team. not sure this is the best way to support it. |
@acederberg Unfortunately, we are going not to accept this PR because:
I think we can keep the issue open to think about it in V3 Thanks for your effort here and sorry for this |
@hramezani No worries, I understand - these are good reasons. Is there any way that I could help with v3? |
Thanks for your understanding ❤️ Right now, we don't have any specific plan for V3. but we can keep the issue open and V3 tag to it to consider it when we are going to work on V3. I am going to close the PR. Thanks for your effort |
I have made this pull request to close my own issue, #346.
I essentially wanted instance level source customization, therefore I added the callback to
_settings_customize_instance
.This change should also help users when testing since they will not have to add
settings_customize_sources
to their class, and will only have to pass_settings_customize_instance
to the constructor.This also includes a small modification to
pyproject.toml
to define test dependencies to improve the developer experience.Sorry that
black
went wild onsettings.py
, there are only3
lines actually added in there. I am assuming that actions will probably fix this, if not, I will fix it.