Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CLI kebab case flag. #489

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

kschwab
Copy link
Contributor

@kschwab kschwab commented Dec 1, 2024

Fixes #469.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Ss]ubcommand

@kschwab kschwab marked this pull request as draft December 2, 2024 04:11
@kschwab kschwab marked this pull request as ready for review December 3, 2024 05:46
@hramezani
Copy link
Member

Thanks @kschwab for this PR.
The changes LGTM 👍 . let's wait for @braindevices feedback on the issue

@braindevices
Copy link

@kschwab thanks a lot! it is perfect now.

@hramezani hramezani merged commit 7bcb6ed into pydantic:main Dec 3, 2024
23 checks passed
@kschwab kschwab deleted the cli-kebab-case branch December 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is there way to make both --opt-with-dash and environment variable work at the same time?
3 participants