Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve field value parsing by adding NoDecode and ForceDecode annotations #492

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

hramezani
Copy link
Member

  • Add NoDecode and ForceDecode annotations
  • Add enable_decoding config with the default value of True
  • Add docs

Please let me know if you have better suggestion about the names

@hramezani hramezani force-pushed the improve-value-parsing branch from 5295989 to ad64130 Compare December 3, 2024 13:33
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Vv]alidator

@hramezani hramezani force-pushed the improve-value-parsing branch from ad64130 to a652163 Compare December 3, 2024 13:40
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

pydantic_settings/sources.py Show resolved Hide resolved
pydantic_settings/sources.py Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
@hramezani hramezani force-pushed the improve-value-parsing branch from a652163 to 5748f06 Compare December 4, 2024 08:52
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 total issue(s) found.

docs/index.md Outdated Show resolved Hide resolved
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Cc]onfig

Note: We resolved prior Hyperlint review comments because:

We updated our inline suggestion AI.

We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Vv]alidator
  • [Cc]onfig

@hramezani hramezani merged commit 3667aed into main Dec 9, 2024
23 checks passed
@hramezani hramezani deleted the improve-value-parsing branch December 9, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants