-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit ruff config from wheel distributions #4652
base: main
Are you sure you want to change the base?
Conversation
Thank you very much @carsonyl. I believe it to be important to distribute |
MANIFEST.in
Outdated
@@ -19,3 +19,4 @@ include tox.ini | |||
include setuptools/tests/config/setupcfg_examples.txt | |||
include setuptools/config/*.schema.json | |||
global-exclude *.py[cod] __pycache__ | |||
global-exclude ruff.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ruff.toml
should be included in the sdist as it is important for testing.
The reason why I am waiting to see the review of other maintainers in this PR, is because previously we had a decision to simply install all the files anyway (since we have extra complexity for configuration and it is not like the presence of these files are hindering the functioning of setuptools): #4479. |
Thanks. This issue only came to my attention because I was working with an application that assumed *.toml was for its exclusive use, so it tripped up on the presence of this file. |
https://github.com/pypa/setuptools/blob/main/setuptools/_vendor/ruff.toml is currently being included in wheels, which is probably unintended since it's only relevant to maintainers.