Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit ruff config from wheel distributions #4652

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

carsonyl
Copy link

https://github.com/pypa/setuptools/blob/main/setuptools/_vendor/ruff.toml is currently being included in wheels, which is probably unintended since it's only relevant to maintainers.

@abravalheri
Copy link
Contributor

Thank you very much @carsonyl.

I believe it to be important to distribute ruff.toml in the sdist as it contains configurations important for tests (pytest-ruff).

MANIFEST.in Outdated
@@ -19,3 +19,4 @@ include tox.ini
include setuptools/tests/config/setupcfg_examples.txt
include setuptools/config/*.schema.json
global-exclude *.py[cod] __pycache__
global-exclude ruff.toml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff.toml should be included in the sdist as it is important for testing.

@carsonyl carsonyl changed the title Omit ruff config from distributions Omit ruff config from wheel distributions Sep 27, 2024
@abravalheri
Copy link
Contributor

The reason why I am waiting to see the review of other maintainers in this PR, is because previously we had a decision to simply install all the files anyway (since we have extra complexity for configuration and it is not like the presence of these files are hindering the functioning of setuptools): #4479.

@abravalheri abravalheri requested review from jaraco and removed request for abravalheri November 11, 2024 17:31
@carsonyl
Copy link
Author

Thanks. This issue only came to my attention because I was working with an application that assumed *.toml was for its exclusive use, so it tripped up on the presence of this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants